From 019045d4bd36bc87bb9ea9c679df6e6c69580f2f Mon Sep 17 00:00:00 2001 From: Bharat Ramanathan Date: Mon, 31 Mar 2025 21:04:23 +0530 Subject: [PATCH] fix: resolve review comments from @aiswaryasankarwork --- api/core/ops/weave_trace/entities/weave_trace_entity.py | 3 ++- api/core/ops/weave_trace/weave_trace.py | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/api/core/ops/weave_trace/entities/weave_trace_entity.py b/api/core/ops/weave_trace/entities/weave_trace_entity.py index 1f6b907e74..14c127f884 100644 --- a/api/core/ops/weave_trace/entities/weave_trace_entity.py +++ b/api/core/ops/weave_trace/entities/weave_trace_entity.py @@ -65,7 +65,8 @@ class WeaveTraceModel(WeaveTokenUsage, WeaveMultiModel): v = replace_text_with_content(data=v) if field_name == "inputs": data = { - "messages": v, + "messages": [dict(msg, **{"usage_metadata": usage_metadata, "file_list": file_list}) for msg in + v] if isinstance(v, list) else v, } elif field_name == "outputs": data = { diff --git a/api/core/ops/weave_trace/weave_trace.py b/api/core/ops/weave_trace/weave_trace.py index 33547f2092..ce474f700d 100644 --- a/api/core/ops/weave_trace/weave_trace.py +++ b/api/core/ops/weave_trace/weave_trace.py @@ -279,8 +279,8 @@ class WeaveDataTrace(BaseTraceInstance): attributes = trace_info.metadata attributes["tags"] = ["moderation"] attributes["message_id"] = trace_info.message_id - attributes["start_time"] = (trace_info.start_time or trace_info.message_data.created_at,) - attributes["end_time"] = (trace_info.end_time or trace_info.message_data.updated_at,) + attributes["start_time"] = trace_info.start_time or trace_info.message_data.created_at + attributes["end_time"] = trace_info.end_time or trace_info.message_data.updated_at moderation_run = WeaveTraceModel( id=str(uuid.uuid4()),