From 0625d6a361c410b9e8e7edb59d5c8b409de671d0 Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Mon, 30 Jun 2025 18:22:40 +0800
Subject: [PATCH] fix: not use local time

---
 .../auto-update-setting/index.tsx             | 12 ++++++----
 .../auto-update-setting/utils.spec.ts         | 15 ++++++++++++
 .../auto-update-setting/utils.ts              | 23 +++++++++++++++++++
 3 files changed, 46 insertions(+), 4 deletions(-)
 create mode 100644 web/app/components/plugins/reference-setting-modal/auto-update-setting/utils.spec.ts

diff --git a/web/app/components/plugins/reference-setting-modal/auto-update-setting/index.tsx b/web/app/components/plugins/reference-setting-modal/auto-update-setting/index.tsx
index 49eeba0ec6..3a8d148c34 100644
--- a/web/app/components/plugins/reference-setting-modal/auto-update-setting/index.tsx
+++ b/web/app/components/plugins/reference-setting-modal/auto-update-setting/index.tsx
@@ -8,7 +8,8 @@ import { useTranslation } from 'react-i18next'
 import TimePicker from '@/app/components/base/date-and-time-picker/time-picker'
 import OptionCard from '@/app/components/workflow/nodes/_base/components/option-card'
 import PluginsPicker from './plugins-picker'
-import { dayjsToTimeOfDay, timeOfDayToDayjs } from './utils'
+import { convertLocalSecondsToUTCDaySeconds, convertUTCDaySecondsToLocalSeconds, dayjsToTimeOfDay, timeOfDayToDayjs } from './utils'
+import { useAppContext } from '@/context/app-context'
 
 const i18nPrefix = 'plugin.autoUpdate'
 
@@ -22,6 +23,8 @@ const AutoUpdateSetting: FC<Props> = ({
   onChange,
 }) => {
   const { t } = useTranslation()
+  const { userProfile: { timezone } } = useAppContext()
+
   const {
     strategy_setting,
     upgrade_time_of_day,
@@ -97,9 +100,10 @@ const AutoUpdateSetting: FC<Props> = ({
             <div className='flex items-center justify-between'>
               <Label label={t(`${i18nPrefix}.updateTime`)} />
               <TimePicker
-                value={timeOfDayToDayjs(upgrade_time_of_day)}
-                onChange={v => handleChange('upgrade_time_of_day')(dayjsToTimeOfDay(v))}
-                onClear={() => handleChange('upgrade_time_of_day')(0)}
+                value={timeOfDayToDayjs(convertUTCDaySecondsToLocalSeconds(upgrade_time_of_day, timezone!))}
+                timezone={timezone}
+                onChange={v => handleChange('upgrade_time_of_day')(convertLocalSecondsToUTCDaySeconds(dayjsToTimeOfDay(v), timezone!))}
+                onClear={() => handleChange('upgrade_time_of_day')(convertLocalSecondsToUTCDaySeconds(0, timezone!))}
                 popupClassName='z-[99]'
                 title={t(`${i18nPrefix}.updateTime`)}
                 minuteFilter={minuteFilter}
diff --git a/web/app/components/plugins/reference-setting-modal/auto-update-setting/utils.spec.ts b/web/app/components/plugins/reference-setting-modal/auto-update-setting/utils.spec.ts
new file mode 100644
index 0000000000..57fffb39eb
--- /dev/null
+++ b/web/app/components/plugins/reference-setting-modal/auto-update-setting/utils.spec.ts
@@ -0,0 +1,15 @@
+// write unit test for convertLocalSecondsToUTCDaySeconds
+import { convertLocalSecondsToUTCDaySeconds, convertUTCDaySecondsToLocalSeconds } from './utils'
+
+describe('convertLocalSecondsToUTCDaySeconds', () => {
+  it('should convert local seconds to UTC day seconds correctly', () => {
+    const localTimezone = 'Asia/Shanghai'
+    const utcSeconds = convertLocalSecondsToUTCDaySeconds(0, localTimezone)
+    expect(utcSeconds).toBe((24 - 8) * 3600)
+  })
+
+  it('should convert local seconds to UTC day seconds for a specific time', () => {
+    const localTimezone = 'Asia/Shanghai'
+    expect(convertUTCDaySecondsToLocalSeconds(convertLocalSecondsToUTCDaySeconds(0, localTimezone), localTimezone)).toBe(0)
+  })
+})
diff --git a/web/app/components/plugins/reference-setting-modal/auto-update-setting/utils.ts b/web/app/components/plugins/reference-setting-modal/auto-update-setting/utils.ts
index 3c28b751a7..346a54d50e 100644
--- a/web/app/components/plugins/reference-setting-modal/auto-update-setting/utils.ts
+++ b/web/app/components/plugins/reference-setting-modal/auto-update-setting/utils.ts
@@ -1,5 +1,10 @@
 import type { Dayjs } from 'dayjs'
 import dayjs from 'dayjs'
+import utc from 'dayjs/plugin/utc'
+import timezone from 'dayjs/plugin/timezone'
+
+dayjs.extend(utc)
+dayjs.extend(timezone)
 
 export const timeOfDayToDayjs = (timeOfDay: number): Dayjs => {
   const hours = Math.floor(timeOfDay / 3600)
@@ -8,7 +13,25 @@ export const timeOfDayToDayjs = (timeOfDay: number): Dayjs => {
   return res
 }
 
+export const convertLocalSecondsToUTCDaySeconds = (secondsInDay: number, localTimezone: string): number => {
+  const localDayStart = dayjs().tz(localTimezone).startOf('day')
+  const localTargetTime = localDayStart.add(secondsInDay, 'second')
+  const utcTargetTime = localTargetTime.utc()
+  const utcDayStart = utcTargetTime.startOf('day')
+  const secondsFromUTCMidnight = utcTargetTime.diff(utcDayStart, 'second')
+  return secondsFromUTCMidnight
+}
+
 export const dayjsToTimeOfDay = (date?: Dayjs): number => {
   if(!date) return 0
   return date.hour() * 3600 + date.minute() * 60
 }
+
+export const convertUTCDaySecondsToLocalSeconds = (utcDaySeconds: number, localTimezone: string): number => {
+    const utcDayStart = dayjs().utc().startOf('day')
+    const utcTargetTime = utcDayStart.add(utcDaySeconds, 'second')
+    const localTargetTime = utcTargetTime.tz(localTimezone)
+    const localDayStart = localTargetTime.startOf('day')
+    const secondsInLocalDay = localTargetTime.diff(localDayStart, 'second')
+    return secondsInLocalDay
+}