From 4e1b17332ca52eb3ff11e745d08baab8e299ad4f Mon Sep 17 00:00:00 2001 From: neatguycoding <15627489+NeatGuyCoding@users.noreply.github.com> Date: Tue, 24 Jun 2025 17:11:20 +0800 Subject: [PATCH] feat: refactor: save_document_with_dataset_id, fix error shadowing --- api/services/dataset_service.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/api/services/dataset_service.py b/api/services/dataset_service.py index 49ca98624a..bd2a38f271 100644 --- a/api/services/dataset_service.py +++ b/api/services/dataset_service.py @@ -1075,7 +1075,7 @@ class DocumentService: raise ValueError("No notion info list found.") exist_page_ids = [] exist_document = {} - documents = ( + documents_from_db = ( db.session.query(Document) .filter_by( dataset_id=dataset.id, @@ -1085,8 +1085,8 @@ class DocumentService: ) .all() ) - if documents: - for document in documents: + if documents_from_db: + for document in documents_from_db: data_source_info = json.loads(document.data_source_info) exist_page_ids.append(data_source_info["notion_page_id"]) exist_document[data_source_info["notion_page_id"]] = document.id