From a540aa59e5c90c2587d3138621510c5cdec3e715 Mon Sep 17 00:00:00 2001
From: neatguycoding <15627489+NeatGuyCoding@users.noreply.github.com>
Date: Wed, 25 Jun 2025 20:47:43 +0800
Subject: [PATCH] fix: fix redundant params in log and missing log

---
 api/core/workflow/workflow_entry.py | 2 +-
 api/services/dataset_service.py     | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/api/core/workflow/workflow_entry.py b/api/core/workflow/workflow_entry.py
index 182c54fa77..c0e98db3db 100644
--- a/api/core/workflow/workflow_entry.py
+++ b/api/core/workflow/workflow_entry.py
@@ -300,7 +300,7 @@ class WorkflowEntry:
             return node_instance, generator
         except Exception as e:
             logger.exception(
-                "error while running node_instance, workflow_id=%s, node_id=%s, type=%s, version=%s",
+                "error while running node_instance, node_id=%s, type=%s, version=%s",
                 node_instance.id,
                 node_instance.node_type,
                 node_instance.version(),
diff --git a/api/services/dataset_service.py b/api/services/dataset_service.py
index af1210c19d..a697c9ab7f 100644
--- a/api/services/dataset_service.py
+++ b/api/services/dataset_service.py
@@ -586,6 +586,10 @@ class DatasetService:
             )
         except ProviderTokenNotInitError:
             # If we can't get the embedding model, preserve existing settings
+            logging.warning(
+                f"Failed to initialize embedding model {data['embedding_model_provider']}/{data['embedding_model']}, "
+                f"preserving existing settings"
+            )
             if dataset.embedding_model_provider and dataset.embedding_model:
                 filtered_data["embedding_model_provider"] = dataset.embedding_model_provider
                 filtered_data["embedding_model"] = dataset.embedding_model