From d248d443242c18497926cdd87a226c9ba03dfd03 Mon Sep 17 00:00:00 2001 From: John Wang Date: Fri, 19 May 2023 18:10:12 +0800 Subject: [PATCH] fix: cannot install other tenant app --- api/controllers/console/explore/installed_app.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/api/controllers/console/explore/installed_app.py b/api/controllers/console/explore/installed_app.py index 538ae458c9..779d0f0a6f 100644 --- a/api/controllers/console/explore/installed_app.py +++ b/api/controllers/console/explore/installed_app.py @@ -69,16 +69,18 @@ class InstalledAppsListApi(Resource): parser.add_argument('app_id', type=str, required=True, help='Invalid app_id') args = parser.parse_args() + recommended_app = RecommendedApp.query.filter(RecommendedApp.app_id == args['app_id']).first() + if recommended_app is None: + abort(404, message='App not found') + current_tenant_id = current_user.current_tenant_id app = db.session.query(App).filter( - App.id == args['app_id'], - App.tenant_id == current_tenant_id + App.id == args['app_id'] ).first() + if app is None: abort(404, message='App not found') - recommended_app = RecommendedApp.query.filter(RecommendedApp.app_id == args['app_id']).first() - if recommended_app is None: - abort(404, message='App not found') + if not app.is_public: abort(403, message="You can't install a non-public app")