From d2ac38445874788450fb81b404fe3882331dcdf0 Mon Sep 17 00:00:00 2001
From: JzoNg <jzongcode@gmail.com>
Date: Mon, 23 Jun 2025 11:08:56 +0800
Subject: [PATCH] support re-authorization

---
 .../components/tools/mcp/detail/content.tsx    | 18 +++++++-----------
 web/hooks/use-oauth.ts                         | 14 ++++++--------
 2 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/web/app/components/tools/mcp/detail/content.tsx b/web/app/components/tools/mcp/detail/content.tsx
index 60f2c13b5f..366b4d8b85 100644
--- a/web/app/components/tools/mcp/detail/content.tsx
+++ b/web/app/components/tools/mcp/detail/content.tsx
@@ -25,7 +25,6 @@ import {
   useInvalidateMCPTools,
   useMCPTools,
   useUpdateMCP,
-  useUpdateMCPAuthorizationToken,
   useUpdateMCPTools,
 } from '@/service/use-tools'
 import { openOAuthPopup } from '@/hooks/use-oauth'
@@ -53,7 +52,6 @@ const MCPDetailContent: FC<Props> = ({
   const invalidateMCPTools = useInvalidateMCPTools()
   const { mutateAsync: updateTools, isPending: isUpdating } = useUpdateMCPTools()
   const { mutateAsync: authorizeMcp, isPending: isAuthorizing } = useAuthorizeMCP()
-  const { mutateAsync: updateMCPAuthorizationToken } = useUpdateMCPAuthorizationToken()
   const toolList = data?.tools || []
 
   const handleUpdateTools = useCallback(async () => {
@@ -62,7 +60,7 @@ const MCPDetailContent: FC<Props> = ({
     await updateTools(detail.id)
     invalidateMCPTools(detail.id)
     onUpdate()
-  }, [detail, updateTools])
+  }, [detail, invalidateMCPTools, onUpdate, updateTools])
 
   const { mutate: updateMCP } = useUpdateMCP({
     onSuccess: onUpdate,
@@ -86,17 +84,13 @@ const MCPDetailContent: FC<Props> = ({
     setFalse: hideDeleting,
   }] = useBoolean(false)
 
-  const handleOAuthCallback = async (state: string, code: string) => {
+  const handleOAuthCallback = useCallback((state: string) => {
     if (!isCurrentWorkspaceManager)
       return
     if (detail.id !== state)
       return
-    await updateMCPAuthorizationToken({
-      provider_id: state,
-      authorization_code: code,
-    })
     handleUpdateTools()
-  }
+  }, [detail.id, handleUpdateTools, isCurrentWorkspaceManager])
 
   const handleAuthorize = useCallback(async () => {
     onFirstCreate()
@@ -112,7 +106,7 @@ const MCPDetailContent: FC<Props> = ({
 
     else if (res.authorization_url)
       openOAuthPopup(res.authorization_url, handleOAuthCallback)
-  }, [detail, updateMCP, hideUpdateModal, onUpdate])
+  }, [onFirstCreate, isCurrentWorkspaceManager, detail, authorizeMcp, handleUpdateTools, handleOAuthCallback])
 
   const handleUpdate = useCallback(async (data: any) => {
     if (!detail)
@@ -137,11 +131,12 @@ const MCPDetailContent: FC<Props> = ({
       hideDeleteConfirm()
       onUpdate(true)
     }
-  }, [detail, showDeleting, hideDeleting, hideDeleteConfirm, onUpdate])
+  }, [detail, showDeleting, deleteMCP, hideDeleting, hideDeleteConfirm, onUpdate])
 
   useEffect(() => {
     if (isCreation)
       handleAuthorize()
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [])
 
   if (!detail)
@@ -175,6 +170,7 @@ const MCPDetailContent: FC<Props> = ({
             <Button
               variant='secondary'
               className='w-full'
+              onClick={handleAuthorize}
               disabled={!isCurrentWorkspaceManager}
             >
               <Indicator className='mr-2' color={'green'} />
diff --git a/web/hooks/use-oauth.ts b/web/hooks/use-oauth.ts
index 0fe4d8e926..c4402ff6eb 100644
--- a/web/hooks/use-oauth.ts
+++ b/web/hooks/use-oauth.ts
@@ -6,15 +6,13 @@ export const useOAuthCallback = () => {
   const searchParams = useSearchParams()
 
   useEffect(() => {
-    const code = searchParams.get('code')
-    const state = searchParams.get('state')
+    const MCPProviderID = searchParams.get('mcp_provider_id')
 
-    if (code && state && window.opener) {
+    if (MCPProviderID && window.opener) {
       window.opener.postMessage({
         type: 'oauth_callback',
         payload: {
-          code,
-          state,
+          state: MCPProviderID,
         },
       }, '*')
       window.close()
@@ -22,7 +20,7 @@ export const useOAuthCallback = () => {
   }, [searchParams])
 }
 
-export const openOAuthPopup = (url: string, callback: (state: string, code: string) => void) => {
+export const openOAuthPopup = (url: string, callback: (state: string) => void) => {
   const width = 600
   const height = 600
   const left = window.screenX + (window.outerWidth - width) / 2
@@ -37,8 +35,8 @@ export const openOAuthPopup = (url: string, callback: (state: string, code: stri
   const handleMessage = (event: MessageEvent) => {
     if (event.data?.type === 'oauth_callback') {
       window.removeEventListener('message', handleMessage)
-      const { code, state } = event.data.payload
-      callback(state, code)
+      const { state } = event.data.payload
+      callback(state)
     }
   }