From d4efd8f49150d94a72b5b1398ba828136a37085b Mon Sep 17 00:00:00 2001 From: ZeroZ_JQ Date: Wed, 16 Apr 2025 17:18:48 +0800 Subject: [PATCH] fix: replace InvalidActionError with DatasetInvalidActionError for better error handling in document status updates --- api/controllers/console/datasets/datasets_document.py | 6 +++--- api/controllers/console/datasets/error.py | 6 ++++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/api/controllers/console/datasets/datasets_document.py b/api/controllers/console/datasets/datasets_document.py index c2d51f1770..1e7ea24556 100644 --- a/api/controllers/console/datasets/datasets_document.py +++ b/api/controllers/console/datasets/datasets_document.py @@ -21,8 +21,8 @@ from controllers.console.datasets.error import ( DocumentAlreadyFinishedError, DocumentIndexingError, IndexingEstimateError, - InvalidActionError, InvalidMetadataError, + DatasetInvalidActionError, ) from controllers.console.wraps import ( account_initialization_required, @@ -822,8 +822,8 @@ class DocumentStatusApi(DocumentResource): try: DocumentService.batch_update_document_status(dataset, document_ids, action, current_user) - except services.errors.dataset.InvalidActionError as e: - raise InvalidActionError(str(e)) + except services.errors.account.InvalidActionError as e: + raise DatasetInvalidActionError(str(e)) return {"result": "success"}, 200 diff --git a/api/controllers/console/datasets/error.py b/api/controllers/console/datasets/error.py index 2f00a84de6..02a272e81e 100644 --- a/api/controllers/console/datasets/error.py +++ b/api/controllers/console/datasets/error.py @@ -101,3 +101,9 @@ class ChildChunkDeleteIndexError(BaseHTTPException): error_code = "child_chunk_delete_index_error" description = "Delete child chunk index failed: {message}" code = 500 + + +class DatasetInvalidActionError(BaseHTTPException): + error_code = "dataset_invalid_action" + description = "Invalid action performed on the dataset or its documents." + code = 400