From d62cbd0db64ddf96a488621211c77e26afd155a4 Mon Sep 17 00:00:00 2001 From: cutiechi Date: Wed, 2 Jul 2025 10:01:00 +0800 Subject: [PATCH] feat(api): validate and reject external datasets in document update --- api/controllers/service_api/dataset/document.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/api/controllers/service_api/dataset/document.py b/api/controllers/service_api/dataset/document.py index d64d9df059..7813adca81 100644 --- a/api/controllers/service_api/dataset/document.py +++ b/api/controllers/service_api/dataset/document.py @@ -210,6 +210,9 @@ class DocumentAddByFileApi(DatasetApiResource): if not dataset: raise ValueError("Dataset does not exist.") + + if dataset.provider == "external": + raise ValueError("External datasets are not supported.") indexing_technique = args.get("indexing_technique") or dataset.indexing_technique if not indexing_technique: @@ -300,6 +303,9 @@ class DocumentUpdateByFileApi(DatasetApiResource): if not dataset: raise ValueError("Dataset does not exist.") + + if dataset.provider == "external": + raise ValueError("External datasets are not supported.") # indexing_technique is already set in dataset since this is an update args["indexing_technique"] = dataset.indexing_technique