From ed139a49a39c0029713f893c3ffb19e81c5030e4 Mon Sep 17 00:00:00 2001 From: yunqiqiliang <132561395+yunqiqiliang@users.noreply.github.com> Date: Thu, 17 Jul 2025 16:45:05 +0800 Subject: [PATCH] Fix code style issues for CI checks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove unused imports (time, VectorType) - Replace logger.error with logger.exception for exception handling - Remove redundant exception objects from logging.exception calls - Ensure all Python style checks pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- .../rag/datasource/vdb/clickzetta/clickzetta_vector.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/api/core/rag/datasource/vdb/clickzetta/clickzetta_vector.py b/api/core/rag/datasource/vdb/clickzetta/clickzetta_vector.py index bb98a4a4c8..c6f11424e1 100644 --- a/api/core/rag/datasource/vdb/clickzetta/clickzetta_vector.py +++ b/api/core/rag/datasource/vdb/clickzetta/clickzetta_vector.py @@ -2,7 +2,6 @@ import json import logging import queue import threading -import time import uuid from typing import Any, Optional @@ -13,7 +12,6 @@ from configs import dify_config from core.rag.datasource.vdb.field import Field from core.rag.datasource.vdb.vector_base import BaseVector from core.rag.datasource.vdb.vector_factory import AbstractVectorFactory -from core.rag.datasource.vdb.vector_type import VectorType from core.rag.embedding.embedding_base import Embeddings from core.rag.models.document import Document from models.dataset import Dataset @@ -120,14 +118,14 @@ class ClickzettaVector(BaseVector): result = func(*args, **kwargs) result_queue.put((True, result)) except Exception as e: - logger.error(f"Write task failed: {e}") + logger.exception("Write task failed") result_queue.put((False, e)) finally: cls._write_queue.task_done() except queue.Empty: continue except Exception as e: - logger.error(f"Write worker error: {e}") + logger.exception("Write worker error") def _execute_write(self, func, *args, **kwargs): """Execute a write operation through the queue.""" @@ -231,7 +229,7 @@ class ClickzettaVector(BaseVector): "with the same type" in error_msg): logger.info(f"Vector index already exists: {e}") else: - logger.error(f"Failed to create vector index: {e}") + logger.exception("Failed to create vector index") raise def _create_inverted_index(self, cursor): @@ -466,7 +464,7 @@ class ClickzettaVector(BaseVector): doc = Document(page_content=row[1], metadata=metadata) documents.append(doc) except Exception as e: - logger.error(f"Full-text search failed: {e}") + logger.exception("Full-text search failed") # Fallback to LIKE search if full-text search fails return self._search_by_like(query, **kwargs)