From fb7fbf1fe4bd58704ca0c311630cb0155b061f8a Mon Sep 17 00:00:00 2001
From: Bowen Liang <liangbowen@gf.com.cn>
Date: Wed, 4 Jun 2025 10:05:21 +0800
Subject: [PATCH] random.choice -> secrets.choice

---
 api/core/helper/moderation.py                       | 4 ++--
 api/libs/helper.py                                  | 4 ++--
 api/tests/unit_tests/core/helper/test_ssrf_proxy.py | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/api/core/helper/moderation.py b/api/core/helper/moderation.py
index 6a5982eca4..a324ac2767 100644
--- a/api/core/helper/moderation.py
+++ b/api/core/helper/moderation.py
@@ -1,5 +1,5 @@
 import logging
-import random
+import secrets
 from typing import cast
 
 from core.app.entities.app_invoke_entities import ModelConfigWithCredentialsEntity
@@ -38,7 +38,7 @@ def check_moderation(tenant_id: str, model_config: ModelConfigWithCredentialsEnt
             if len(text_chunks) == 0:
                 return True
 
-            text_chunk = random.choice(text_chunks)
+            text_chunk = secrets.choice(text_chunks)
 
             try:
                 model_provider_factory = ModelProviderFactory(tenant_id)
diff --git a/api/libs/helper.py b/api/libs/helper.py
index afc8f31681..3ee027f318 100644
--- a/api/libs/helper.py
+++ b/api/libs/helper.py
@@ -1,7 +1,7 @@
 import json
 import logging
-import random
 import re
+import secrets
 import string
 import subprocess
 import time
@@ -175,7 +175,7 @@ def generate_string(n):
     letters_digits = string.ascii_letters + string.digits
     result = ""
     for i in range(n):
-        result += random.choice(letters_digits)
+        result += secrets.choice(letters_digits)
 
     return result
 
diff --git a/api/tests/unit_tests/core/helper/test_ssrf_proxy.py b/api/tests/unit_tests/core/helper/test_ssrf_proxy.py
index c688d3952b..37749f0c66 100644
--- a/api/tests/unit_tests/core/helper/test_ssrf_proxy.py
+++ b/api/tests/unit_tests/core/helper/test_ssrf_proxy.py
@@ -1,4 +1,4 @@
-import random
+import secrets
 from unittest.mock import MagicMock, patch
 
 import pytest
@@ -34,7 +34,7 @@ def test_retry_logic_success(mock_request):
     side_effects = []
 
     for _ in range(SSRF_DEFAULT_MAX_RETRIES):
-        status_code = random.choice(STATUS_FORCELIST)
+        status_code = secrets.choice(STATUS_FORCELIST)
         mock_response = MagicMock()
         mock_response.status_code = status_code
         side_effects.append(mock_response)