You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gcgj-dify-1.7.0/api/core/app/apps
zxhlyh 4d36e784b7 merge main 7 months ago
..
advanced_chat refactor: elegant event dispatch patterns (92% complexity reduction) (#22600) 7 months ago
agent_chat refactor: decouple Node and NodeData (#22581) 7 months ago
chat refactor: decouple Node and NodeData (#22581) 7 months ago
common Merge branch 'main' into feat/r2 7 months ago
completion refactor: decouple Node and NodeData (#22581) 7 months ago
pipeline r2 transform 7 months ago
workflow refactor: elegant event dispatch patterns (92% complexity reduction) (#22600) 7 months ago
README.md fix: some typos using typos (#11374) 1 year ago
__init__.py FEAT: NEW WORKFLOW ENGINE (#3160) 2 years ago
base_app_generate_response_converter.py Introduce Plugins (#13836) 12 months ago
base_app_generator.py fix(api): Fix resetting sys var causing internal server error (#21604) 7 months ago
base_app_queue_manager.py refactor: decouple Node and NodeData (#22581) 7 months ago
base_app_runner.py refactor: decouple Node and NodeData (#22581) 7 months ago
exc.py refactor: decouple Node and NodeData (#22581) 7 months ago
message_based_app_generator.py Fix/replace datetime patterns with naive utc now (#22654) 7 months ago
message_based_app_queue_manager.py refactor: decouple Node and NodeData (#22581) 7 months ago
workflow_app_runner.py refactor(api): Separate SegmentType for Integer/Float to Enable Pydantic Serialization (#22025) 7 months ago

README.md

Guidelines for Database Connection Management in App Runner and Task Pipeline

Due to the presence of tasks in App Runner that require long execution times, such as LLM generation and external requests, Flask-Sqlalchemy's strategy for database connection pooling is to allocate one connection (transaction) per request. This approach keeps a connection occupied even during non-DB tasks, leading to the inability to acquire new connections during high concurrency requests due to multiple long-running tasks.

Therefore, the database operations in App Runner and Task Pipeline must ensure connections are closed immediately after use, and it's better to pass IDs rather than Model objects to avoid detach errors.

Examples:

  1. Creating a new record:

    app = App(id=1)
    db.session.add(app)
    db.session.commit()
    db.session.refresh(app)  # Retrieve table default values, like created_at, cached in the app object, won't affect after close
    
    # Handle non-long-running tasks or store the content of the App instance in memory (via variable assignment).
    
    db.session.close()
    
    return app.id
    
  2. Fetching a record from the table:

    app = db.session.query(App).filter(App.id == app_id).first()
    
    created_at = app.created_at
    
    db.session.close()
    
    # Handle tasks (include long-running).
    
    
  3. Updating a table field:

    app = db.session.query(App).filter(App.id == app_id).first()
    
    app.updated_at = time.utcnow()
    db.session.commit()
    db.session.close()
    
    return app_id