You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gcgj-dify-1.7.0/api/core/app/apps
-LAN- 66a62e6c13
refactor(api/core/app/apps/base_app_generator.py): improve input validation and sanitization in BaseAppGenerator (#5866)
2 years ago
..
advanced_chat chore: apply flake8-comprehensions Ruff rules to improve collection comprehensions (#5652) 2 years ago
agent_chat chore: apply flake8-comprehensions Ruff rules to improve collection comprehensions (#5652) 2 years ago
chat chore: apply flake8-comprehensions Ruff rules to improve collection comprehensions (#5652) 2 years ago
completion feat: add ops trace (#5483) 2 years ago
workflow feat: add ops trace (#5483) 2 years ago
README.md FEAT: NEW WORKFLOW ENGINE (#3160) 2 years ago
__init__.py FEAT: NEW WORKFLOW ENGINE (#3160) 2 years ago
base_app_generate_response_converter.py fix event/stream ping (#3553) 2 years ago
base_app_generator.py refactor(api/core/app/apps/base_app_generator.py): improve input validation and sanitization in BaseAppGenerator (#5866) 2 years ago
base_app_queue_manager.py improve: mordernizing validation by migrating pydantic from 1.x to 2.x (#4592) 2 years ago
base_app_runner.py feat: add ops trace (#5483) 2 years ago
message_based_app_generator.py feat: add ops trace (#5483) 2 years ago
message_based_app_queue_manager.py FEAT: NEW WORKFLOW ENGINE (#3160) 2 years ago
workflow_logging_callback.py Feat/workflow phase2 (#4687) 2 years ago

README.md

Guidelines for Database Connection Management in App Runner and Task Pipeline

Due to the presence of tasks in App Runner that require long execution times, such as LLM generation and external requests, Flask-Sqlalchemy's strategy for database connection pooling is to allocate one connection (transaction) per request. This approach keeps a connection occupied even during non-DB tasks, leading to the inability to acquire new connections during high concurrency requests due to multiple long-running tasks.

Therefore, the database operations in App Runner and Task Pipeline must ensure connections are closed immediately after use, and it's better to pass IDs rather than Model objects to avoid deattach errors.

Examples:

  1. Creating a new record:

    app = App(id=1)
    db.session.add(app)
    db.session.commit()
    db.session.refresh(app)  # Retrieve table default values, like created_at, cached in the app object, won't affect after close
    
    # Handle non-long-running tasks or store the content of the App instance in memory (via variable assignment).
    
    db.session.close()
    
    return app.id
    
  2. Fetching a record from the table:

    app = db.session.query(App).filter(App.id == app_id).first()
    
    created_at = app.created_at
    
    db.session.close()
    
    # Handle tasks (include long-running).
    
    
  3. Updating a table field:

    app = db.session.query(App).filter(App.id == app_id).first()
    
    app.updated_at = time.utcnow()
    db.session.commit()
    db.session.close()
    
    return app_id