refactor: replace DatasetInvalidActionError with InvalidActionError for consistent error handling in document status updates

pull/18148/head
ZeroZ_JQ 1 year ago
parent b90ba55c04
commit 3259485d66

@ -18,11 +18,11 @@ from controllers.console.app.error import (
) )
from controllers.console.datasets.error import ( from controllers.console.datasets.error import (
ArchivedDocumentImmutableError, ArchivedDocumentImmutableError,
DatasetInvalidActionError,
DocumentAlreadyFinishedError, DocumentAlreadyFinishedError,
DocumentIndexingError, DocumentIndexingError,
IndexingEstimateError, IndexingEstimateError,
InvalidMetadataError, InvalidMetadataError,
InvalidActionError,
) )
from controllers.console.wraps import ( from controllers.console.wraps import (
account_initialization_required, account_initialization_required,
@ -823,7 +823,7 @@ class DocumentStatusApi(DocumentResource):
try: try:
DocumentService.batch_update_document_status(dataset, document_ids, action, current_user) DocumentService.batch_update_document_status(dataset, document_ids, action, current_user)
except services.errors.account.InvalidActionError as e: except services.errors.account.InvalidActionError as e:
raise DatasetInvalidActionError(str(e)) raise InvalidActionError(str(e))
return {"result": "success"}, 200 return {"result": "success"}, 200

@ -102,8 +102,3 @@ class ChildChunkDeleteIndexError(BaseHTTPException):
description = "Delete child chunk index failed: {message}" description = "Delete child chunk index failed: {message}"
code = 500 code = 500
class DatasetInvalidActionError(BaseHTTPException):
error_code = "dataset_invalid_action"
description = "Invalid action performed on the dataset or its documents."
code = 400

@ -372,4 +372,3 @@ class DocumentStatusApi(DatasetApiResource):
api.add_resource(DatasetListApi, "/datasets") api.add_resource(DatasetListApi, "/datasets")
api.add_resource(DatasetApi, "/datasets/<uuid:dataset_id>") api.add_resource(DatasetApi, "/datasets/<uuid:dataset_id>")
api.add_resource(DocumentStatusApi, "/datasets/<uuid:dataset_id>/documents/status/<string:action>")

Loading…
Cancel
Save