refactor: improve layout and event handling in Header and FieldItem components

pull/21398/head
twwu 12 months ago
parent 468bfdfed9
commit 91fefa0e37

@ -30,8 +30,9 @@ const Header = ({
)}> )}>
{title} {title}
</div> </div>
<Divider type='vertical' className='mx-1 h-3.5' />
{!isInPipeline && ( {!isInPipeline && (
<>
<Divider type='vertical' className='mx-1 h-3.5' />
<Button <Button
variant='secondary' variant='secondary'
size='small' size='small'
@ -45,6 +46,7 @@ const Header = ({
{buttonText} {buttonText}
</span> </span>
</Button> </Button>
</>
)} )}
</div> </div>
<a <a

@ -35,12 +35,14 @@ const FieldItem = ({
const ref = useRef(null) const ref = useRef(null)
const isHovering = useHover(ref) const isHovering = useHover(ref)
const handleOnClickEdit = useCallback(() => { const handleOnClickEdit = useCallback((e: React.MouseEvent) => {
e.stopPropagation()
if (readonly) return if (readonly) return
onClickEdit(payload.variable) onClickEdit(payload.variable)
}, [onClickEdit, payload.variable, readonly]) }, [onClickEdit, payload.variable, readonly])
const handleRemove = useCallback(() => { const handleRemove = useCallback((e: React.MouseEvent) => {
e.stopPropagation()
if (readonly) return if (readonly) return
onRemove(index) onRemove(index)
}, [index, onRemove, readonly]) }, [index, onRemove, readonly])

@ -1,6 +1,6 @@
import { useCallback, useEffect, useMemo, useState } from 'react' import { useCallback, useEffect, useMemo, useState } from 'react'
import WorkspaceSelector from '@/app/components/base/notion-page-selector/workspace-selector' import WorkspaceSelector from '@/app/components/base/notion-page-selector/workspace-selector'
import SearchInput from '@/app/education-apply/search-input' import SearchInput from '@/app/components/base/notion-page-selector/search-input'
import PageSelector from '@/app/components/base/notion-page-selector/page-selector' import PageSelector from '@/app/components/base/notion-page-selector/page-selector'
import type { DataSourceNotionPageMap, DataSourceNotionWorkspace, NotionPage } from '@/models/common' import type { DataSourceNotionPageMap, DataSourceNotionWorkspace, NotionPage } from '@/models/common'
import Header from '@/app/components/datasets/create/website/base/header' import Header from '@/app/components/datasets/create/website/base/header'
@ -36,12 +36,15 @@ const NotionPageSelector = ({
const getNotionData = useCallback(async () => { const getNotionData = useCallback(async () => {
if (pipeline_id) { if (pipeline_id) {
const notionData = await getNotionPages({ await getNotionPages({
pipeline_id, pipeline_id,
node_id: nodeId, node_id: nodeId,
inputs: {}, inputs: {},
}) as DataSourceNotionWorkspace[] }, {
setNotionData(notionData) onSuccess(notionData) {
setNotionData(notionData as DataSourceNotionWorkspace[])
},
})
} }
}, [getNotionPages, nodeId, pipeline_id]) }, [getNotionPages, nodeId, pipeline_id])

Loading…
Cancel
Save