bugfix: simplify major check logic

pull/21891/head
ytqh 1 year ago
parent 7a37c58b2b
commit b59c856f29

@ -106,12 +106,15 @@ class UserProfile(Resource):
if 'major' in data: if 'major' in data:
major = data['major'] major = data['major']
if not isinstance(major, str): # Allow None as a valid value (to clear the field)
return {"success": False, "message": "Major must be a string value"}, 400 if major is None:
if len(major) > 50: validated_data['major'] = None
elif not isinstance(major, str):
return {"success": False, "message": "Major must be a string value or null"}, 400
elif len(major) > 50:
return {"success": False, "message": "Major exceeds maximum length of 50"}, 400 return {"success": False, "message": "Major exceeds maximum length of 50"}, 400
else:
validated_data['major'] = major validated_data['major'] = major
# Use the service to update user profile # Use the service to update user profile
success, error = EndUserService.update_user_profile(end_user, validated_data) success, error = EndUserService.update_user_profile(end_user, validated_data)

Loading…
Cancel
Save