refactor: optimize locale setting by removing unnecessary async/await and restructuring language resource loading

pull/22810/head
twwu 10 months ago
parent c6e5d3c7ee
commit c8f0951504

@ -83,28 +83,51 @@ const Panel: FC = () => {
const hasConfiguredTracing = !!(langSmithConfig || langFuseConfig || opikConfig || weaveConfig || arizeConfig || phoenixConfig || aliyunConfig) const hasConfiguredTracing = !!(langSmithConfig || langFuseConfig || opikConfig || weaveConfig || arizeConfig || phoenixConfig || aliyunConfig)
const fetchTracingConfig = async () => { const fetchTracingConfig = async () => {
const getArizeConfig = async () => {
const { tracing_config: arizeConfig, has_not_configured: arizeHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.arize }) const { tracing_config: arizeConfig, has_not_configured: arizeHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.arize })
if (!arizeHasNotConfig) if (!arizeHasNotConfig)
setArizeConfig(arizeConfig as ArizeConfig) setArizeConfig(arizeConfig as ArizeConfig)
}
const getPhoenixConfig = async () => {
const { tracing_config: phoenixConfig, has_not_configured: phoenixHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.phoenix }) const { tracing_config: phoenixConfig, has_not_configured: phoenixHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.phoenix })
if (!phoenixHasNotConfig) if (!phoenixHasNotConfig)
setPhoenixConfig(phoenixConfig as PhoenixConfig) setPhoenixConfig(phoenixConfig as PhoenixConfig)
}
const getLangSmithConfig = async () => {
const { tracing_config: langSmithConfig, has_not_configured: langSmithHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.langSmith }) const { tracing_config: langSmithConfig, has_not_configured: langSmithHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.langSmith })
if (!langSmithHasNotConfig) if (!langSmithHasNotConfig)
setLangSmithConfig(langSmithConfig as LangSmithConfig) setLangSmithConfig(langSmithConfig as LangSmithConfig)
}
const getLangFuseConfig = async () => {
const { tracing_config: langFuseConfig, has_not_configured: langFuseHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.langfuse }) const { tracing_config: langFuseConfig, has_not_configured: langFuseHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.langfuse })
if (!langFuseHasNotConfig) if (!langFuseHasNotConfig)
setLangFuseConfig(langFuseConfig as LangFuseConfig) setLangFuseConfig(langFuseConfig as LangFuseConfig)
}
const getOpikConfig = async () => {
const { tracing_config: opikConfig, has_not_configured: OpikHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.opik }) const { tracing_config: opikConfig, has_not_configured: OpikHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.opik })
if (!OpikHasNotConfig) if (!OpikHasNotConfig)
setOpikConfig(opikConfig as OpikConfig) setOpikConfig(opikConfig as OpikConfig)
}
const getWeaveConfig = async () => {
const { tracing_config: weaveConfig, has_not_configured: weaveHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.weave }) const { tracing_config: weaveConfig, has_not_configured: weaveHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.weave })
if (!weaveHasNotConfig) if (!weaveHasNotConfig)
setWeaveConfig(weaveConfig as WeaveConfig) setWeaveConfig(weaveConfig as WeaveConfig)
}
const getAliyunConfig = async () => {
const { tracing_config: aliyunConfig, has_not_configured: aliyunHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.aliyun }) const { tracing_config: aliyunConfig, has_not_configured: aliyunHasNotConfig } = await doFetchTracingConfig({ appId, provider: TracingProvider.aliyun })
if (!aliyunHasNotConfig) if (!aliyunHasNotConfig)
setAliyunConfig(aliyunConfig as AliyunConfig) setAliyunConfig(aliyunConfig as AliyunConfig)
} }
Promise.all([
getArizeConfig(),
getPhoenixConfig(),
getLangSmithConfig(),
getLangFuseConfig(),
getOpikConfig(),
getWeaveConfig(),
getAliyunConfig(),
])
}
const handleTracingConfigUpdated = async (provider: TracingProvider) => { const handleTracingConfigUpdated = async (provider: TracingProvider) => {
// call api to hide secret key value // call api to hide secret key value
@ -155,7 +178,6 @@ const Panel: FC = () => {
await fetchTracingConfig() await fetchTracingConfig()
setLoaded() setLoaded()
})() })()
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []) }, [])
const [controlShowPopup, setControlShowPopup] = useState<number>(0) const [controlShowPopup, setControlShowPopup] = useState<number>(0)

@ -32,7 +32,7 @@ export default function LanguagePage() {
await updateUserProfile({ url, body: { [bodyKey]: item.value } }) await updateUserProfile({ url, body: { [bodyKey]: item.value } })
notify({ type: 'success', message: t('common.actionMsg.modifiedSuccessfully') }) notify({ type: 'success', message: t('common.actionMsg.modifiedSuccessfully') })
await setLocaleOnClient(item.value.toString()) setLocaleOnClient(item.value.toString())
} }
catch (e) { catch (e) {
notify({ type: 'error', message: (e as Error).message }) notify({ type: 'error', message: (e as Error).message })

@ -1,11 +1,10 @@
'use client' 'use client'
import type { FC } from 'react' import type { FC } from 'react'
import React, { useEffect, useState } from 'react' import React, { useEffect } from 'react'
import I18NContext from '@/context/i18n' import I18NContext from '@/context/i18n'
import type { Locale } from '@/i18n' import type { Locale } from '@/i18n'
import { setLocaleOnClient } from '@/i18n' import { setLocaleOnClient } from '@/i18n'
import Loading from './base/loading'
export type II18nProps = { export type II18nProps = {
locale: Locale locale: Locale
@ -15,17 +14,10 @@ const I18n: FC<II18nProps> = ({
locale, locale,
children, children,
}) => { }) => {
const [loading, setLoading] = useState(true)
useEffect(() => { useEffect(() => {
setLocaleOnClient(locale, false).then(() => { setLocaleOnClient(locale, false)
setLoading(false)
})
}, [locale]) }, [locale])
if (loading)
return <div className='flex h-screen w-screen items-center justify-center'><Loading type='app' /></div>
return ( return (
<I18NContext.Provider value={{ <I18NContext.Provider value={{
locale, locale,

@ -4,8 +4,8 @@ import Link from 'next/link'
import cn from '@/utils/classnames' import cn from '@/utils/classnames'
import { RiAlertFill } from '@remixicon/react' import { RiAlertFill } from '@remixicon/react'
import { Trans } from 'react-i18next' import { Trans } from 'react-i18next'
import { snakeCase2CamelCase } from '@/utils/format'
import { useMixedTranslation } from '../marketplace/hooks' import { useMixedTranslation } from '../marketplace/hooks'
import { camelCase } from 'lodash-es'
type DeprecationNoticeProps = { type DeprecationNoticeProps = {
status: 'deleted' | 'active' status: 'deleted' | 'active'
@ -36,7 +36,7 @@ const DeprecationNotice: FC<DeprecationNoticeProps> = ({
const deprecatedReasonKey = useMemo(() => { const deprecatedReasonKey = useMemo(() => {
if (!deprecatedReason) return '' if (!deprecatedReason) return ''
return snakeCase2CamelCase(deprecatedReason) return camelCase(deprecatedReason)
}, [deprecatedReason]) }, [deprecatedReason])
// Check if the deprecatedReasonKey exists in i18n // Check if the deprecatedReasonKey exists in i18n

@ -36,8 +36,8 @@ const Header = () => {
<Select <Select
value={locale} value={locale}
items={languages.filter(item => item.supported)} items={languages.filter(item => item.supported)}
onChange={async (value) => { onChange={(value) => {
await setLocaleOnClient(value as Locale) setLocaleOnClient(value as Locale)
}} }}
/> />
<Divider type='vertical' className='mx-0 ml-2 h-4' /> <Divider type='vertical' className='mx-0 ml-2 h-4' />

@ -57,7 +57,7 @@ export default function InviteSettingsPage() {
if (res.result === 'success') { if (res.result === 'success') {
localStorage.setItem('console_token', res.data.access_token) localStorage.setItem('console_token', res.data.access_token)
localStorage.setItem('refresh_token', res.data.refresh_token) localStorage.setItem('refresh_token', res.data.refresh_token)
await setLocaleOnClient(language, false) setLocaleOnClient(language, false)
router.replace('/apps') router.replace('/apps')
} }
} }

@ -9,15 +9,13 @@ import { noop } from 'lodash-es'
type II18NContext = { type II18NContext = {
locale: Locale locale: Locale
i18n: Record<string, any> i18n: Record<string, any>
setLocaleOnClient: (_lang: Locale, _reloadPage?: boolean) => Promise<void> setLocaleOnClient: (_lang: Locale, _reloadPage?: boolean) => void
} }
const I18NContext = createContext<II18NContext>({ const I18NContext = createContext<II18NContext>({
locale: 'en-US', locale: 'en-US',
i18n: {}, i18n: {},
setLocaleOnClient: async () => { setLocaleOnClient: noop,
noop()
},
}) })
export const useI18N = () => useContext(I18NContext) export const useI18N = () => useContext(I18NContext)

@ -1,49 +1,59 @@
'use client' 'use client'
import i18n from 'i18next' import i18n from 'i18next'
import { camelCase } from 'lodash-es'
import { initReactI18next } from 'react-i18next' import { initReactI18next } from 'react-i18next'
const requireSilent = async (lang: string) => { const requireSilent = async (lang: string, namespace: string) => {
let res let res
try { try {
res = (await import(`./${lang}/education`)).default res = (await import(`./${lang}/${namespace}`)).default
} }
catch { catch {
res = (await import('./en-US/education')).default res = (await import(`./en-US/${namespace}`)).default
} }
return res return res
} }
export const loadLangResources = async (lang: string) => ({ const NAMESPACES = [
translation: { 'app-annotation',
common: (await import(`./${lang}/common`)).default, 'app-api',
layout: (await import(`./${lang}/layout`)).default, 'app-debug',
login: (await import(`./${lang}/login`)).default, 'app-log',
register: (await import(`./${lang}/register`)).default, 'app-overview',
app: (await import(`./${lang}/app`)).default, 'app',
appOverview: (await import(`./${lang}/app-overview`)).default, 'billing',
appDebug: (await import(`./${lang}/app-debug`)).default, 'common',
appApi: (await import(`./${lang}/app-api`)).default, 'custom',
appLog: (await import(`./${lang}/app-log`)).default, 'dataset-creation',
appAnnotation: (await import(`./${lang}/app-annotation`)).default, 'dataset-documents',
share: (await import(`./${lang}/share-app`)).default, 'dataset-hit-testing',
dataset: (await import(`./${lang}/dataset`)).default, 'dataset-settings',
datasetDocuments: (await import(`./${lang}/dataset-documents`)).default, 'dataset',
datasetHitTesting: (await import(`./${lang}/dataset-hit-testing`)).default, 'education',
datasetSettings: (await import(`./${lang}/dataset-settings`)).default, 'explore',
datasetCreation: (await import(`./${lang}/dataset-creation`)).default, 'layout',
explore: (await import(`./${lang}/explore`)).default, 'login',
billing: (await import(`./${lang}/billing`)).default, 'plugin-tags',
custom: (await import(`./${lang}/custom`)).default, 'plugin',
tools: (await import(`./${lang}/tools`)).default, 'register',
workflow: (await import(`./${lang}/workflow`)).default, 'run-log',
runLog: (await import(`./${lang}/run-log`)).default, 'share-app',
plugin: (await import(`./${lang}/plugin`)).default, 'time',
pluginTags: (await import(`./${lang}/plugin-tags`)).default, 'tools',
time: (await import(`./${lang}/time`)).default, 'workflow',
education: (await requireSilent(lang)).default, ]
},
}) export const loadLangResources = async (lang: string) => {
const modules = await Promise.all(NAMESPACES.map(ns => requireSilent(lang, ns)))
const resources = modules.reduce((acc, mod, index) => {
acc[camelCase(NAMESPACES[index])] = mod
return acc
}, {} as Record<string, any>)
return {
translation: resources,
}
}
i18n.use(initReactI18next) i18n.use(initReactI18next)
.init({ .init({

@ -13,7 +13,7 @@ export type Locale = typeof i18n['locales'][number]
export const setLocaleOnClient = async (locale: Locale, reloadPage = true) => { export const setLocaleOnClient = async (locale: Locale, reloadPage = true) => {
Cookies.set(LOCALE_COOKIE_NAME, locale, { expires: 365 }) Cookies.set(LOCALE_COOKIE_NAME, locale, { expires: 365 })
await changeLanguage(locale) changeLanguage(locale)
reloadPage && location.reload() reloadPage && location.reload()
} }

@ -56,7 +56,3 @@ export const downloadFile = ({ data, fileName }: { data: Blob; fileName: string
a.remove() a.remove()
window.URL.revokeObjectURL(url) window.URL.revokeObjectURL(url)
} }
export const snakeCase2CamelCase = (input: string): string => {
return input.replace(/_([a-z])/g, (_, letter) => letter.toUpperCase())
}

Loading…
Cancel
Save